public/dropshell
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove overly aggressive lock from ds_run.sh
All checks were successful
Build-Test-Publish / build (linux/amd64) (push) Successful in 29s
Details
Build-Test-Publish / build (linux/arm64) (push) Successful in 1m8s
Details

Browse Source 
The lock in ds_run.sh prevented concurrent status/logs/ports checks
which are read-only operations.

Locks should only be on mutating operations:
- install (already locked in ds_install.sh)
- uninstall (add to uninstall.sh)
- destroy (add to destroy.sh)
- restore (add to restore.sh)
This commit is contained in:
j
2026-04-04 10:36:16 +13:00
parent 7416288c71
commit 1c29215785
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/agent-remote/ds_run.sh
View File

@@ -77,9 +77,6 @@ export TEMPLATE_PATH="${DROPSHELL_DIR}/services/${SERVICE}/template"
[[ -f "${DROPSHELL_DIR}/server_info.env" ]] || _die "Missing ${DROPSHELL_DIR}/server_info.env" [[ -f "${DROPSHELL_DIR}/server_info.env" ]] || _die "Missing ${DROPSHELL_DIR}/server_info.env"
[[ -d "${CONFIG_PATH}" ]] || _die "Service '${SERVICE}' does not exist on server (missing ${CONFIG_PATH})" [[ -d "${CONFIG_PATH}" ]] || _die "Service '${SERVICE}' does not exist on server (missing ${CONFIG_PATH})"
# -- Acquire exclusive lock (released automatically on exit) --
_lock_service "${DROPSHELL_DIR}/services/${SERVICE}"
# -- Load template info (template defaults, loaded first) -- # -- Load template info (template defaults, loaded first) --
export TEMPLATE_INFO_ENV="${TEMPLATE_PATH}/template_info.env" export TEMPLATE_INFO_ENV="${TEMPLATE_PATH}/template_info.env"
if [[ ! -f "${TEMPLATE_INFO_ENV}" ]]; then if [[ ! -f "${TEMPLATE_INFO_ENV}" ]]; then